amaliujia commented on code in PR #43010:
URL: https://github.com/apache/spark/pull/43010#discussion_r1333802817
##########
python/pyspark/sql/connect/plan.py:
##########
@@ -1192,6 +1192,7 @@ def plan(self, session: "SparkConnectClient") ->
proto.Relation:
assert self._child is not None
plan = proto.Relation()
+ plan.common.plan_id = self._child._plan_id
Review Comment:
I am doing this because `CollectMetrics` does not re-use `LogicalPlan`'s
`_create_proto_relation` which helps set the `plan_id`. Looks like majority of
the plans set the `plan_id` by default. However I do not have context on why
`CollectMetrcis` is implemented by the current way.
cc @zhengruifeng
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
