LuciferYang commented on code in PR #43010:
URL: https://github.com/apache/spark/pull/43010#discussion_r1338768534
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala:
##########
@@ -1969,7 +1969,8 @@ trait SupportsSubquery extends LogicalPlan
case class CollectMetrics(
name: String,
metrics: Seq[NamedExpression],
- child: LogicalPlan)
+ child: LogicalPlan,
+ dataframeId: Long)
Review Comment:
GA can pass the test now, which seems to be because the test order makes
`sparkTestRelation.id` exactly 0. However, the test arrangement order of Maven
is different from sbt, so `sparkTestRelation.id` is not 0 when using maven
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
