Ngone51 commented on code in PR #43112:
URL: https://github.com/apache/spark/pull/43112#discussion_r1336601652
##########
core/src/test/scala/org/apache/spark/storage/BlockManagerSuite.scala:
##########
@@ -133,12 +133,12 @@ class BlockManagerSuite extends SparkFunSuite with
Matchers with PrivateMethodTe
val bmSecurityMgr = new SecurityManager(bmConf, encryptionKey)
val serializerManager = new SerializerManager(serializer, bmConf,
encryptionKey)
val transfer = transferService.getOrElse(new NettyBlockTransferService(
- conf, securityMgr, serializerManager, "localhost", "localhost", 0, 1))
+ bmConf, securityMgr, serializerManager, "localhost", "localhost", 0, 1))
Review Comment:
It's a bug. `makeBlockManager` should use `testConf` instead of global
`conf` when `testConf` exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
