Ngone51 commented on code in PR #43112:
URL: https://github.com/apache/spark/pull/43112#discussion_r1336859200
##########
core/src/main/scala/org/apache/spark/storage/BlockManager.scala:
##########
@@ -527,7 +527,9 @@ private[spark] class BlockManager(
logInfo(s"external shuffle service port = $externalShuffleServicePort")
shuffleServerId = BlockManagerId(executorId,
blockTransferService.hostName,
externalShuffleServicePort)
- if (!isDriver) {
+ // Do not try to register with the external shuffle server under testing
since none of
+ // test modes (local, local-cluster) enables shuffle service.
+ if (!isDriver && !Utils.isTesting) {
Review Comment:
It turns out some tests rely on this creation failure for testing purposes.
I added a separate testing conf (`spark.testing.skipESSRegister`) to keep the
default behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
