galacticgumshoe commented on code in PR #52: URL: https://github.com/apache/spark-docker/pull/52#discussion_r1344576380
########## 3.4.1/scala2.12-java11-ubuntu/Dockerfile: ########## @@ -43,8 +43,8 @@ ENV SPARK_TGZ_URL=https://archive.apache.org/dist/spark/spark-3.4.1/spark-3.4.1- RUN set -ex; \ export SPARK_TMP="$(mktemp -d)"; \ cd $SPARK_TMP; \ - wget -nv -O spark.tgz "$SPARK_TGZ_URL"; \ - wget -nv -O spark.tgz.asc "$SPARK_TGZ_ASC_URL"; \ + wget -nv -O spark.tgz "${SPARK_TGZ_URL}"; \ + wget -nv -O spark.tgz.asc "${SPARK_TGZ_ASC_URL}"; \ Review Comment: So while not technically required, this is a result of the changes in the PR to the Dockerfile.template following running the add-docker files.sh script against 3.4.1. I will back out the brackets in the template and rerun to remove these brackets from the generated Dockerfile here. Just documenting the cause of this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
