galacticgumshoe commented on code in PR #52: URL: https://github.com/apache/spark-docker/pull/52#discussion_r1344702801
########## 3.4.1/scala2.12-java11-ubuntu/Dockerfile: ########## @@ -43,8 +43,8 @@ ENV SPARK_TGZ_URL=https://archive.apache.org/dist/spark/spark-3.4.1/spark-3.4.1- RUN set -ex; \ export SPARK_TMP="$(mktemp -d)"; \ cd $SPARK_TMP; \ - wget -nv -O spark.tgz "$SPARK_TGZ_URL"; \ - wget -nv -O spark.tgz.asc "$SPARK_TGZ_ASC_URL"; \ + wget -nv -O spark.tgz "${SPARK_TGZ_URL}"; \ + wget -nv -O spark.tgz.asc "${SPARK_TGZ_ASC_URL}"; \ Review Comment: Please note that since I merged in the changes from master in 81c2933 that had merged after this PR was initiated, that pulled in changes also to the entrypoint.sh.template. So after making the change to the Dockerfile.template and rerunning add-dockerfiles.sh, both the Dockerfile and entrypoint.sh for 3.4.1/2.12 has been changed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
