hasnain-db commented on PR #43289: URL: https://github.com/apache/spark/pull/43289#issuecomment-1752380733
> Another question is, are we sure that network-yarn needs to shade the netty-tcnative-boringssl-static related jar packages? If indeed necessary, should we rename libnetty_tcnative_* in a similar way to libnetty_transport*? I am not sure if it *needs* to shade them. I'll admit I'm not the most familiar with this aspect of things, happy to try it without. I will say that even with the shading it does seem to work fine (tests in https://github.com/apache/spark/pull/42685 pass) so aside from this issue I am not sure about the harm of keeping it shaded for consistency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
