hasnain-db commented on PR #43289: URL: https://github.com/apache/spark/pull/43289#issuecomment-1752388058
> This depends on whether the YarnShuffleService needs the tcnative-boringssl related functions. If so, it indeed needs to be shaded, and libnetty_tcnative_* should likely be renamed similarly; if not, these jars can be directly excluded from the shade. If it's not provided, the functionality will still work, it'll just be slower (falling back to the JDK implementation). I think for now for simplicity's sake (especially since I don't have a great setup for testing yarn beyond unit tests) I think it makes sense to exclude from the shading, that seems simpler. Will try that out -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
