grundprinzip commented on code in PR #43311:
URL: https://github.com/apache/spark/pull/43311#discussion_r1352598429
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2461,48 +2475,39 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
def process(
command: proto.Command,
- responseObserver: StreamObserver[ExecutePlanResponse],
- executeHolder: ExecuteHolder): Unit = {
+ responseObserver: StreamObserver[ExecutePlanResponse]): Unit = {
Review Comment:
Conceptually, this shouldn't be an issue because it's not really a public
API. but it's not backwards compatible.
This is particularly interesting because you went through some length to fix
this problem in the constructor though.
@hvanhovell Do we consider the SparkConenct planner to be public? Probably,
not correct?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
