juliuszsompolski commented on code in PR #43311:
URL: https://github.com/apache/spark/pull/43311#discussion_r1353107388
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -2461,48 +2475,39 @@ class SparkConnectPlanner(val sessionHolder:
SessionHolder) extends Logging {
def process(
command: proto.Command,
- responseObserver: StreamObserver[ExecutePlanResponse],
- executeHolder: ExecuteHolder): Unit = {
+ responseObserver: StreamObserver[ExecutePlanResponse]): Unit = {
Review Comment:
FWIW, between Spark 3.4 and Spark 3.5, these interfaces also changed.
For example https://github.com/apache/spark/pull/41618 made it take a
SessionHolder instead of SparkSession, so that various parameters don't have to
be passed to it lossely. This PR adding ExecuteHolder to it is in a very
similar spirit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
