zhaomin1423 commented on code in PR #43371:
URL: https://github.com/apache/spark/pull/43371#discussion_r1360016315
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1933,6 +1946,29 @@ public RoaringBitmap getMapTracker() {
int getNumIOExceptions() {
return numIOExceptions;
}
+
+ AppAttemptShuffleMergeId getAppAttemptShuffleMergeId() {
+ return appAttemptShuffleMergeId;
+ }
+
+ int getReduceId() {
+ return reduceId;
+ }
+
+ private record ResourceCleaner(
+ File dataFile,
+ FileChannel dataChannel,
+ MergeShuffleFile indexFile,
+ MergeShuffleFile metaFile,
+ AppAttemptShuffleMergeId appAttemptShuffleMergeId,
+ int reduceId) implements Runnable {
Review Comment:
From api doc of java.lang.ref.Cleaner.
```
The cleaning action is invoked only after the associated object becomes
phantom reachable, so it is important that the object implementing the cleaning
action does not hold references to the object.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
