mridulm commented on code in PR #43371:
URL: https://github.com/apache/spark/pull/43371#discussion_r1360130919
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1864,7 +1875,14 @@ private void finalizePartition() throws IOException {
metaFile.getChannel().truncate(metaFile.getPos());
}
- void closeAllFilesAndDeleteIfNeeded(boolean delete) {
+ static void closeAllFilesAndDeleteIfNeeded(
Review Comment:
This method can be made `private`
##########
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java:
##########
@@ -1864,7 +1875,14 @@ private void finalizePartition() throws IOException {
metaFile.getChannel().truncate(metaFile.getPos());
}
- void closeAllFilesAndDeleteIfNeeded(boolean delete) {
+ static void closeAllFilesAndDeleteIfNeeded(
Review Comment:
This method can be made `private` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
