beliefer commented on code in PR #43390:
URL: https://github.com/apache/spark/pull/43390#discussion_r1361577350
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MsSqlServerDialect.scala:
##########
@@ -128,6 +128,7 @@ private object MsSqlServerDialect extends JdbcDialect {
case BinaryType => Some(JdbcType("VARBINARY(MAX)",
java.sql.Types.VARBINARY))
case ShortType if !SQLConf.get.legacyMsSqlServerNumericMappingEnabled =>
Some(JdbcType("SMALLINT", java.sql.Types.SMALLINT))
+ case ByteType => Option(JdbcType("TINYINT", java.sql.Types.TINYINT))
Review Comment:
@michaelzhan-db The range of MsSqlServer's TINYINT from 0 to 255. But Spark
ByteType could represent the negative value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
