beliefer commented on code in PR #43390:
URL: https://github.com/apache/spark/pull/43390#discussion_r1363047316
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -93,8 +93,8 @@ private case object MySQLDialect extends JdbcDialect with
SQLConfHelper {
// byte arrays instead of longs.
md.putLong("binarylong", 1)
Option(LongType)
- } else if (sqlType == Types.BIT && typeName.equals("TINYINT")) {
- Option(BooleanType)
Review Comment:
Please don't remove the two lines.
I don't know the original intention of these two lines of code.
##########
sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala:
##########
@@ -912,8 +912,8 @@ class JDBCSuite extends QueryTest with SharedSparkSession {
Some(LongType))
assert(metadata.build().contains("binarylong"))
assert(mySqlDialect.getCatalystType(java.sql.Types.VARBINARY, "BIT", 1,
metadata) == None)
- assert(mySqlDialect.getCatalystType(java.sql.Types.BIT, "TINYINT", 1,
metadata) ==
- Some(BooleanType))
Review Comment:
Please don't remove the two lines.
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/MySQLIntegrationSuite.scala:
##########
@@ -54,10 +55,10 @@ class MySQLIntegrationSuite extends
DockerJDBCIntegrationSuite {
conn.prepareStatement("INSERT INTO tbl VALUES (42,'fred')").executeUpdate()
conn.prepareStatement("INSERT INTO tbl VALUES (17,'dave')").executeUpdate()
- conn.prepareStatement("CREATE TABLE numbers (onebit BIT(1), tenbits
BIT(10), "
+ conn.prepareStatement("CREATE TABLE numbers (onebit BIT(1), tenbits
BIT(10), tiny TINYINT, "
Review Comment:
Shall we add `tiny TINYINT` at last?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
