rangadi commented on code in PR #43424:
URL: https://github.com/apache/spark/pull/43424#discussion_r1364757563
##########
connector/protobuf/src/test/scala/org/apache/spark/sql/protobuf/ProtobufCatalystDataConversionSuite.scala:
##########
@@ -137,7 +137,7 @@ class ProtobufCatalystDataConversionSuite
while (
data != null &&
(data.get(0) == defaultValue ||
- (dt == BinaryType &&
+ (dt.fields(0).dataType == BinaryType &&
Review Comment:
This fixes flake reported in
https://github.com/apache/spark/pull/43413#issuecomment-1769286752
The type check was incorrect. So when the random value was empty array, we
didn't skip it. Original intention is to skip default values for types.
Verified with manually setting the seed to 399 (at line 128).
cc: @HeartSaVioR
<img width="1480" alt="image"
src="https://github.com/apache/spark/assets/502522/94a8aca2-328c-4371-9067-f0ff18d59574";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
