HyukjinKwon commented on code in PR #43444:
URL: https://github.com/apache/spark/pull/43444#discussion_r1366330564
##########
python/pyspark/testing/utils.py:
##########
@@ -592,7 +616,7 @@ def assert_rows_equal(rows1: List[Row], rows2: List[Row]):
rows_str2 += str(r2) + "\n"
if not compare_rows(r1, r2):
diff_rows_cnt += 1
- diff_rows = True
+ diff_rows.append((r1, r2))
Review Comment:
@itholic let's optimize this. if `includeDiffRows` is disabled, we don't
need to keep the diff rows which costs memory.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
