itholic commented on code in PR #43444:
URL: https://github.com/apache/spark/pull/43444#discussion_r1373988507
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,6 +34,7 @@ def __init__(
message: Optional[str] = None,
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
+ data: Optional[Iterable["Row"]] = None,
Review Comment:
I initially added this parameter as a member of the super
class(`PySparkException`) considering future expansion. For example, we could
consider the case of later extending this member in `PySparkValueError` or
`PySparkTypeError` to find problematic values or types.
But it's true that this is currently only used for the logic related to
`PySparkAssertionError`.
Can I ask you opinion, @HyukjinKwon ? Should we keep this parameter here as
it is, or move into `PySparkAssertionError`?
##########
python/pyspark/errors/exceptions/base.py:
##########
@@ -31,6 +34,7 @@ def __init__(
message: Optional[str] = None,
error_class: Optional[str] = None,
message_parameters: Optional[Dict[str, str]] = None,
+ data: Optional[Iterable["Row"]] = None,
Review Comment:
I initially added this parameter as a member of the super
class(`PySparkException`) considering future expansion. For example, we could
consider the case of later extending this member in `PySparkValueError` or
`PySparkTypeError` to find problematic values or types.
But it's true that this is currently only used for the logic related to
`PySparkAssertionError`.
Can I ask you opinion, @HyukjinKwon ? Should we keep this parameter here as
it is, or move into `PySparkAssertionError`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
