beliefer commented on code in PR #43469:
URL: https://github.com/apache/spark/pull/43469#discussion_r1367653717
##########
python/pyspark/sql/connect/client/core.py:
##########
@@ -945,7 +956,7 @@ def explain_string(self, plan: pb2.Plan, explain_mode: str
= "extended") -> str:
return result
def execute_command(
- self, command: pb2.Command
+ self, command: pb2.Command, observations: Dict[str, Observation]
Review Comment:
I think observations should be optional.
##########
python/pyspark/sql/tests/connect/client/test_client.py:
##########
@@ -44,7 +44,7 @@ def test_user_agent_passthrough(self):
client._stub = mock
command = proto.Command()
- client.execute_command(command)
+ client.execute_command(command, observations={})
Review Comment:
Shall we avoid pass empty observations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
