MaxGekk commented on PR #43469:
URL: https://github.com/apache/spark/pull/43469#issuecomment-1777072652

   Can this PR cause the errors?
   ```
   annotations failed mypy checks:
   python/pyspark/sql/connect/client/core.py:808: error: "ObservedMetrics" has 
no attribute "keys"  [attr-defined]
   Found 1 error in 1 file (checked 709 source files)
   1
   Error: Process completed with exit code 1.
   ```
   and
   ```
   python/pyspark/sql/tests/connect/test_connect_basic.py.test_observe
   keys
   
   Traceback (most recent call last):
     File 
"/__w/spark/spark/python/pyspark/sql/tests/connect/test_connect_basic.py", line 
1782, in test_observe
       self.connect.read.table(self.tbl_name)
     File "/__w/spark/spark/python/pyspark/sql/connect/dataframe.py", line 
1730, in toPandas
       return self._session.client.to_pandas(query, self._plan.observations)
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
849, in to_pandas
       table, schema, metrics, observed_metrics, _ = self._execute_and_fetch(
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
1301, in _execute_and_fetch
       for response in self._execute_and_fetch_as_iterator(req, observations):
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
1279, in _execute_and_fetch_as_iterator
       self._handle_error(error)
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
1527, in _handle_error
       raise error
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
1272, in _execute_and_fetch_as_iterator
       yield from handle_response(b)
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
1205, in handle_response
       for observed_metrics in self._build_observed_metrics(b.observed_metrics):
     File "/__w/spark/spark/python/pyspark/sql/connect/client/core.py", line 
808, in <genexpr>
       return (PlanObservedMetrics(x.name, [v for v in x.values], list(x.keys)) 
for x in metrics)
   AttributeError: keys
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to