Yikun commented on code in PR #56:
URL: https://github.com/apache/spark-docker/pull/56#discussion_r1367866420
##########
versions.json:
##########
@@ -1,9 +1,38 @@
{
"versions": [
+ {
+ "path": "3.5.0/scala2.12-java17-python3-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-python3-ubuntu",
+ "3.5.0-java17-python3",
+ "3.5.0-java17",
+ "python3-java17"
+ ]
+ },
+ {
+ "path": "3.5.0/scala2.12-java17-r-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-r-ubuntu",
+ "3.5.0-java-17-r"
+ ]
+ },
+ {
+ "path": "3.5.0/scala2.12-java17-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-ubuntu",
+ "3.5.0-java17-scala"
+ ]
+ },
+ {
+ "path": "3.5.0/scala2.12-java17-python3-r-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-python3-r-ubuntu"
+ ]
+ },
{
"path": "3.5.0/scala2.12-java11-python3-ubuntu",
"tags": [
- "3.5.0-scala2.12-java11-python3-ubuntu",
+ "3.5.0-scala2.12-java17-python3-ubuntu",
Review Comment:
This shouldn't be changed.
##########
testing/testing.sh:
##########
@@ -61,7 +61,8 @@ function remove_network() {
# Find and kill any remaining containers attached to the network
function cleanup() {
- local containers
+ local containers
+
Review Comment:
unrelated change
##########
versions.json:
##########
@@ -1,9 +1,38 @@
{
"versions": [
+ {
+ "path": "3.5.0/scala2.12-java17-python3-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-python3-ubuntu",
+ "3.5.0-java17-python3",
+ "3.5.0-java17",
+ "python3-java17"
+ ]
+ },
+ {
+ "path": "3.5.0/scala2.12-java17-r-ubuntu",
+ "tags": [
+ "3.5.0-scala2.12-java17-r-ubuntu",
+ "3.5.0-java-17-r"
Review Comment:
```suggestion
"3.5.0-java17-r"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]