vakarisbk commented on PR #56: URL: https://github.com/apache/spark-docker/pull/56#issuecomment-1774127165
> Please also make sure: > > 1. All dockerfiles and entrypoint.sh should be generated by `add-dockerfiles.sh` All dockerfiles and entrypoints were generated using the add-dockerfiles.sh To validate, I ran this diff: ``` mv 3.5.0 3.5.0_copy; \ ./add-dockerfiles.sh 3.5.0; \ diff -r 3.5.0 3.5.0_copy; ``` > 2. It would be better if you can publish these images in your local repo to test (by appending a local change line in your local branch .github/workflows/publish.yml L50), It's just a test but shouldn't be changed in this PR. I've published the images in my [forked repository](https://github.com/vakarisbk/spark-docker/pkgs/container/spark-docker%2Fspark). Publish job logs can be found [here](https://github.com/vakarisbk/spark-docker/actions/runs/6604314223/job/17938533429). Let me know if anything else is needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
