cloud-fan commented on code in PR #43403:
URL: https://github.com/apache/spark/pull/43403#discussion_r1368307092
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/DataSourceV2SQLSuite.scala:
##########
@@ -2928,29 +2932,34 @@ class DataSourceV2SQLSuiteV1Filter
sql(s"INSERT INTO $t4 VALUES (7)")
sql(s"INSERT INTO $t4 VALUES (8)")
- assert(sql("SELECT * FROM t TIMESTAMP AS OF '2019-01-29
00:37:58'").collect()
- === Array(Row(5), Row(6)))
- assert(sql("SELECT * FROM t TIMESTAMP AS OF '2021-01-29
00:00:00'").collect()
- === Array(Row(7), Row(8)))
- assert(sql(s"SELECT * FROM t TIMESTAMP AS OF $ts1InSeconds").collect()
- === Array(Row(5), Row(6)))
- assert(sql(s"SELECT * FROM t TIMESTAMP AS OF $ts2InSeconds").collect()
- === Array(Row(7), Row(8)))
- assert(sql(s"SELECT * FROM t FOR SYSTEM_TIME AS OF
$ts1InSeconds").collect()
- === Array(Row(5), Row(6)))
- assert(sql(s"SELECT * FROM t FOR SYSTEM_TIME AS OF
$ts2InSeconds").collect()
- === Array(Row(7), Row(8)))
- assert(sql("SELECT * FROM t TIMESTAMP AS OF make_date(2021, 1,
29)").collect()
- === Array(Row(7), Row(8)))
- assert(sql("SELECT * FROM t TIMESTAMP AS OF to_timestamp('2021-01-29
00:00:00')").collect()
- === Array(Row(7), Row(8)))
+ val res1_sql = sql("SELECT * FROM t TIMESTAMP AS OF '2019-01-29
00:37:58'").collect()
+ assert(res1_sql === Array(Row(5), Row(6)))
+ val res1_df = spark.read.option("timestampAsOf", "2019-01-29
00:37:58").table("t").collect()
+ assert(res1_df === Array(Row(5), Row(6)))
+ val res2_sql = sql("SELECT * FROM t TIMESTAMP AS OF '2021-01-29
00:00:00'").collect()
+ assert(res2_sql === Array(Row(7), Row(8)))
+ val res2_df = spark.read.option("timestampAsOf", "2021-01-29
00:00:00").table("t").collect()
+ assert(res2_df === Array(Row(7), Row(8)))
+
+ val res3 = sql(s"SELECT * FROM t TIMESTAMP AS OF
$ts1InSeconds").collect()
+ assert(res3 === Array(Row(5), Row(6)))
+ val res4 = sql(s"SELECT * FROM t TIMESTAMP AS OF
$ts2InSeconds").collect()
+ assert(res4 === Array(Row(7), Row(8)))
+ val res5 = sql(s"SELECT * FROM t FOR SYSTEM_TIME AS OF
$ts1InSeconds").collect()
+ assert(res5 === Array(Row(5), Row(6)))
+ val res6 = sql(s"SELECT * FROM t FOR SYSTEM_TIME AS OF
$ts2InSeconds").collect()
+ assert(res6 === Array(Row(7), Row(8)))
+ val res7 = sql("SELECT * FROM t TIMESTAMP AS OF make_date(2021, 1,
29)").collect()
+ assert(res7 === Array(Row(7), Row(8)))
+ val res8 = sql("SELECT * FROM t TIMESTAMP AS OF to_timestamp('2021-01-29
00:00:00')").collect()
+ assert(res8 === Array(Row(7), Row(8)))
// Scalar subquery is also supported.
- assert(sql("SELECT * FROM t TIMESTAMP AS OF (SELECT make_date(2021, 1,
29))").collect()
- === Array(Row(7), Row(8)))
+ val res9 = sql("SELECT * FROM t TIMESTAMP AS OF (SELECT make_date(2021,
1, 29))")
+ assert(res9.collect() === Array(Row(7), Row(8)))
Review Comment:
```suggestion
val res9 = sql("SELECT * FROM t TIMESTAMP AS OF (SELECT
make_date(2021, 1, 29))").collect()
assert(res9 === Array(Row(7), Row(8)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
