yaooqinn commented on code in PR #43403:
URL: https://github.com/apache/spark/pull/43403#discussion_r1369786851


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2207,6 +2213,11 @@
           "Must be deterministic."
         ]
       },
+      "OPTION" : {
+        "message" : [
+          "Timestamp string in the options should use ISO standard format such 
as 'yyyy-MM-dd HH:mm:ss'."

Review Comment:
   
   
   Yes,it's defined in the ANSI SQL Standard in BNF form
   ```bnf
   <unquoted timestamp string> ::=
     <unquoted date string> <space> <unquoted time string>
   
   ```
   
![image](https://github.com/apache/spark/assets/8326978/fa5c026e-41c5-40d4-a32c-c76a0a17cb7d)
   



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2207,6 +2213,11 @@
           "Must be deterministic."
         ]
       },
+      "OPTION" : {
+        "message" : [
+          "Timestamp string in the options should use ISO standard format such 
as 'yyyy-MM-dd HH:mm:ss'."

Review Comment:
   
   
   Yes,it's defined in the ANSI SQL Standard in BNF form
   ```bnf
   <unquoted timestamp string> ::=
     <unquoted date string> <space> <unquoted time string>
   
   ```
   
![image](https://github.com/apache/spark/assets/8326978/fa5c026e-41c5-40d4-a32c-c76a0a17cb7d)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to