mridulm commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1374038863
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -182,23 +189,21 @@ public boolean skip(long n) {
@Override
public synchronized void close() throws IOException {
- db.notifyIteratorClosed(this);
if (!closed) {
- it.close();
- closed = true;
- next = null;
+ try {
+ cleanable.clean();
Review Comment:
I am not necessarily saying it is an incorrect change - I have not analyzed
in detail.
But in context of `Cleaner` related change, I would have expected the
modifications to be equivalent and not require MT safety impact :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
