LuciferYang commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1374090070
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -280,4 +285,23 @@ static int compare(byte[] a, byte[] b) {
return a.length - b.length;
}
+ private record ResourceCleaner(DBIterator dbIterator, LevelDB levelDB)
implements Runnable {
+ @Override
+ public void run() {
+ levelDB.getIteratorTracker().removeIf(ref -> {
+ LevelDBIterator<?> levelDBIterator = ref.get();
+ return levelDBIterator != null &&
dbIterator.equals(levelDBIterator.it);
Review Comment:
> Given this is enhancement for finalize -> Cleaner, it is fine to simply
use existing semantics and change this condition to simply dbIterator ==
levelDBIterator.it, thoughts ?
hmm... `levelDBIterator` is `ref.get`, if `levelDBIterator` is null,
`levelDBIterator.it` will throw NPE ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
