zhaomin1423 commented on code in PR #43502:
URL: https://github.com/apache/spark/pull/43502#discussion_r1376483755
##########
common/kvstore/src/main/java/org/apache/spark/util/kvstore/LevelDBIterator.java:
##########
@@ -182,23 +189,21 @@ public boolean skip(long n) {
@Override
public synchronized void close() throws IOException {
- db.notifyIteratorClosed(this);
if (!closed) {
- it.close();
- closed = true;
- next = null;
+ try {
+ cleanable.clean();
Review Comment:
> I personally prefer to keep the method of manually closing as it is
through some refactoring, without locking the db.
sorry, I don't undenstand this implementation how to do it?
```
/**
* Closes the given iterator if the DB is still open. Trying to close a
JNI LevelDB handle
* with a closed DB can cause JVM crashes, so this ensures that situation
does not happen.
*/
void closeIterator(LevelDBIterator<?> it) throws IOException {
notifyIteratorClosed(it);
synchronized (this._db) {
DB _db = this._db.get();
if (_db != null) {
it.close();
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
