Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6406#discussion_r31046934
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/SimpleDateParam.scala ---
@@ -25,8 +25,19 @@ import javax.ws.rs.core.Response.Status
import scala.util.Try
private[v1] class SimpleDateParam(val originalValue: String) {
+
+ private val formats: Seq[SimpleDateFormat] = {
--- End diff --
Now this is a field though. There's no need for that. The format objects
can be created on demand to parse the input. If this `SimpleDateParam` object
is short-lived I suppose it does not matter much but I would have just inlined
all this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
