Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6406#discussion_r31049678
--- Diff:
core/src/main/scala/org/apache/spark/status/api/v1/SimpleDateParam.scala ---
@@ -25,8 +25,18 @@ import javax.ws.rs.core.Response.Status
import scala.util.Try
private[v1] class SimpleDateParam(val originalValue: String) {
+
val timestamp: Long = {
- SimpleDateParam.formats.collectFirst {
+ val formats: Seq[SimpleDateFormat] = {
--- End diff --
OK... but this seems like a very complicated way of saying, "parse with one
format, and if it fails, parse with the other. Why not just boil this down
while we're here? you can even avoid allocating at least one of the two objects
in most cases.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
