LuciferYang commented on code in PR #43637:
URL: https://github.com/apache/spark/pull/43637#discussion_r1380166945
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -362,10 +362,8 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
case s: Seq[_] =>
s.map(mapChild)
case m: Map[_, _] =>
- // `map.mapValues().view.force` return `Map` in Scala 2.12 but return
`IndexedSeq` in Scala
- // 2.13, call `toMap` method manually to compatible with Scala 2.12
and Scala 2.13
- // `mapValues` is lazy and we need to force it to materialize
- m.view.mapValues(mapChild).view.force.toMap
+ // `mapValues` is lazy and we need to force it to materialize by
invoking `toIndexedSeq`
+ m.view.mapValues(mapChild).view.toIndexedSeq.toMap
Review Comment:
How about just `m.view.mapValues(mapChild).toMap`?
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -784,13 +782,12 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
arg.asInstanceOf[BaseType].clone()
case Some(arg: TreeNode[_]) if containsChild(arg) =>
Some(arg.asInstanceOf[BaseType].clone())
- // `map.mapValues().view.force` return `Map` in Scala 2.12 but return
`IndexedSeq` in Scala
- // 2.13, call `toMap` method manually to compatible with Scala 2.12 and
Scala 2.13
+ // `mapValues` is lazy and we need to force it to materialize by
invoking `toIndexedSeq`
case m: Map[_, _] => m.view.mapValues {
case arg: TreeNode[_] if containsChild(arg) =>
arg.asInstanceOf[BaseType].clone()
case other => other
- }.view.force.toMap // `mapValues` is lazy and we need to force it to
materialize
+ }.view.toIndexedSeq.toMap
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
