dongjoon-hyun commented on code in PR #43637:
URL: https://github.com/apache/spark/pull/43637#discussion_r1380825014
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala:
##########
@@ -362,10 +362,8 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]]
case s: Seq[_] =>
s.map(mapChild)
case m: Map[_, _] =>
- // `map.mapValues().view.force` return `Map` in Scala 2.12 but return
`IndexedSeq` in Scala
- // 2.13, call `toMap` method manually to compatible with Scala 2.12
and Scala 2.13
- // `mapValues` is lazy and we need to force it to materialize
- m.view.mapValues(mapChild).view.force.toMap
+ // `mapValues` is lazy and we need to force it to materialize by
converting to Map
Review Comment:
Is this, `we need to force it to materialize`, correct with the new code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
