wbo4958 commented on PR #43494: URL: https://github.com/apache/spark/pull/43494#issuecomment-1809672224
> Need to check barrier scheduling algorithm, which checks for max slots to make sure this doesn't break that. > > I'm also curious if you are getting warnings out from the warnOnWastedResources function when setting things like this? Maybe its bypassing those checks, but like getNumSlotsPerAddress which you removed usage in code is still used for those warnings. Yeah. Added the tests for barrier scheduling. please refer to [here](https://github.com/apache/spark/pull/43494/files#diff-9c73792f401d6969f0a4c33839f22d37354a4ee4e33020287bb4b3c2973fd4ecR2303) and [here](https://github.com/apache/spark/pull/43494/files#diff-9c73792f401d6969f0a4c33839f22d37354a4ee4e33020287bb4b3c2973fd4ecR2349) and [here](https://github.com/apache/spark/pull/43494/files#diff-9c73792f401d6969f0a4c33839f22d37354a4ee4e33020287bb4b3c2973fd4ecR2406) and [here](https://github.com/apache/spark/pull/43494/files#diff-9c73792f401d6969f0a4c33839f22d37354a4ee4e33020287bb4b3c2973fd4ecR2454) and tests for warnOnWastedResources, please refer to [here](https://github.com/apache/spark/pull/43494/files#diff-6e4265cf1ad3e318e98ae4148871f7953b21772d4dad1b4c733d17d91165f54bR341) and [here](https://github.com/apache/spark/pull/43494/files#diff-6e4265cf1ad3e318e98ae4148871f7953b21772d4dad1b4c733d17d91165f54bR441) and [here](https://github.com/apache/spark/pull/43494/files#diff-6e4265cf1ad3e318e98ae4148871f7953b21772d4dad1b4c733d17d91165f54bR511) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
