tgravescs commented on code in PR #43494:
URL: https://github.com/apache/spark/pull/43494#discussion_r1399408216


##########
core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala:
##########
@@ -171,16 +171,16 @@ private[spark] object ResourceUtils extends Logging {
   // integer amount and the number of slots per address. For instance, if the 
amount is 0.5,

Review Comment:
   there are comments in function getSchedulerTaskResourceAmount that need to 
change based  on these new changes. Its also unclear to me from your response 
whether that function and warnOnWastedResources are still used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to