HeartSaVioR commented on code in PR #43831:
URL: https://github.com/apache/spark/pull/43831#discussion_r1395306567
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSourceTestBase.scala:
##########
@@ -18,16 +18,27 @@ package org.apache.spark.sql.execution.datasources.v2.state
import java.sql.Timestamp
+import org.scalatest.BeforeAndAfter
+
import org.apache.spark.sql.{DataFrame, Dataset}
import org.apache.spark.sql.execution.streaming.MemoryStream
+import org.apache.spark.sql.execution.streaming.state.StateStore
import org.apache.spark.sql.functions._
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.streaming._
import org.apache.spark.sql.streaming.util.StreamManualClock
-trait StateDataSourceTestBase extends StreamTest with StateStoreMetricsTest {
+trait StateDataSourceTestBase extends StreamTest with BeforeAndAfter with
StateStoreMetricsTest {
Review Comment:
Arguably we can defer the cleanup of temp directory till VM shutdown or test
suite cleanup and move this to afterAll, but we do this for stream-stream join
test suite already, so would like to be consistent with existing practice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
