dongjoon-hyun commented on code in PR #43831:
URL: https://github.com/apache/spark/pull/43831#discussion_r1395351760
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/v2/state/StateDataSourceTestBase.scala:
##########
@@ -18,16 +18,27 @@ package org.apache.spark.sql.execution.datasources.v2.state
import java.sql.Timestamp
+import org.scalatest.BeforeAndAfter
+
import org.apache.spark.sql.{DataFrame, Dataset}
import org.apache.spark.sql.execution.streaming.MemoryStream
+import org.apache.spark.sql.execution.streaming.state.StateStore
import org.apache.spark.sql.functions._
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.streaming._
import org.apache.spark.sql.streaming.util.StreamManualClock
-trait StateDataSourceTestBase extends StreamTest with StateStoreMetricsTest {
+trait StateDataSourceTestBase extends StreamTest with BeforeAndAfter with
StateStoreMetricsTest {
Review Comment:
The reason why I requested is that `BeforeAndAfter` is deprecated,
@HeartSaVioR . I hope we follow the `scalatest` recommendation in Apache Spark
4.0.0.
- https://www.scalatest.org/scaladoc/1.4.1/org/scalatest/BeforeAndAfter.html
> This trait has been deprecated and will be removed in a future version of
ScalaTest. If you are only using its beforeEach and/or afterEach methods, mix
in BeforeAndAfterEach instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
