wbo4958 commented on code in PR #43494:
URL: https://github.com/apache/spark/pull/43494#discussion_r1399864198
##########
core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala:
##########
@@ -171,16 +171,16 @@ private[spark] object ResourceUtils extends Logging {
// integer amount and the number of slots per address. For instance, if the
amount is 0.5,
Review Comment:
Yes, `getSchedulerTaskResourceAmount` is only used by warnOnWastedResources
to calculate the max task number per executor, please refer to
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/ResourceUtils.scala#L474-L476),
while warnOnWastedResources will be used when checking resource profile, or
calculateTasksAndLimitingResource, Please refer to
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala#L228)
and
[here](https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/SparkContext.scala#L3155)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
