Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6400#discussion_r31089678
  
    --- Diff: 
sql/hive/src/test/scala/org/apache/spark/sql/sources/hadoopFsRelationSuites.scala
 ---
    @@ -76,6 +76,12 @@ abstract class HadoopFsRelationTest extends QueryTest 
with SQLTestUtils {
           df.filter('a > 1 && 'p1 < 2).select('b, 'p1),
           for (i <- 2 to 3; _ <- Seq("foo", "bar")) yield Row(s"val_$i", 1))
    --- End diff --
    
    Are you sure that `p1` is string-typed?  I think that `p2` is, but there's 
other code which implies that `p1` should be an int.
    
    e.g. at the top of `HadoopFsRelationTest`:
    
    ```scala
      val partitionedTestDF1 = (for {
        i <- 1 to 3
        p2 <- Seq("foo", "bar")
      } yield (i, s"val_$i", 1, p2)).toDF("a", "b", "p1", "p2")
    
      val partitionedTestDF2 = (for {
        i <- 1 to 3
        p2 <- Seq("foo", "bar")
      } yield (i, s"val_$i", 2, p2)).toDF("a", "b", "p1", "p2")
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to