Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/6400#discussion_r31100453
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ExistingRDD.scala ---
@@ -31,26 +31,19 @@ import org.apache.spark.sql.{Row, SQLContext}
*/
@DeveloperApi
object RDDConversions {
- def productToRowRdd[A <: Product](data: RDD[A], schema: StructType):
RDD[Row] = {
+ def productToRowRdd[A <: Product](data: RDD[A], outputTypes:
Seq[DataType]): RDD[Row] = {
data.mapPartitions { iterator =>
- if (iterator.isEmpty) {
- Iterator.empty
- } else {
- val bufferedIterator = iterator.buffered
- val mutableRow = new
SpecificMutableRow(schema.fields.map(_.dataType))
- val schemaFields = schema.fields.toArray
- val converters = schemaFields.map {
- f => CatalystTypeConverters.createToCatalystConverter(f.dataType)
- }
- bufferedIterator.map { r =>
- var i = 0
- while (i < mutableRow.length) {
- mutableRow(i) = converters(i)(r.productElement(i))
- i += 1
- }
-
- mutableRow
+ val numColumns = outputTypes.length
+ val mutableRow = new GenericMutableRow(numColumns)
+ val converters =
outputTypes.map(CatalystTypeConverters.createToCatalystConverter)
+ iterator.map { r =>
--- End diff --
Actually, I am fine with the current version. We are not slower than the
previous version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
