cloud-fan commented on code in PR #43926:
URL: https://github.com/apache/spark/pull/43926#discussion_r1401555960
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2961,6 +2961,12 @@
],
"sqlState" : "42601"
},
+ "SPARK_JOB_CANCELLED" : {
+ "message" : [
+ "Job <jobId> cancelled <reason>"
+ ],
+ "sqlState" : "XXKDA"
Review Comment:
This is my last concern. We need this error class as users can trigger it
using RDD APIs. But RDD API is kind of internal now, and we don't expect users
to call them directly.
To confirm, SQL users won't hit it, right? Image the user canceled a query,
but the AQE loop is still running and submitted some more jobs, this failure
will be swallowed and not propagated to users, rigjt? also cc @liuzqt
##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -2961,6 +2961,12 @@
],
"sqlState" : "42601"
},
+ "SPARK_JOB_CANCELLED" : {
+ "message" : [
+ "Job <jobId> cancelled <reason>"
+ ],
+ "sqlState" : "XXKDA"
Review Comment:
This is my last concern. We need this error class as users can trigger it
using RDD APIs. But RDD API is kind of internal now, and we don't expect users
to call them directly.
To confirm, SQL users won't hit it, right? Image the user canceled a query,
but the AQE loop is still running and submitted some more jobs, this failure
will be swallowed and not propagated to users, right? also cc @liuzqt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
