anchovYu commented on code in PR #43926:
URL: https://github.com/apache/spark/pull/43926#discussion_r1402477697
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -1264,14 +1280,24 @@ private[spark] class DAGScheduler(
listenerBus.post(SparkListenerTaskGettingResult(taskInfo))
}
- private[scheduler] def handleJobSubmitted(jobId: Int,
+ private[scheduler] def handleJobSubmitted(
+ jobId: Int,
finalRDD: RDD[_],
func: (TaskContext, Iterator[_]) => _,
partitions: Array[Int],
callSite: CallSite,
listener: JobListener,
artifacts: JobArtifactSet,
properties: Properties): Unit = {
+ // If this job belongs to a cancelled job group, skip running it
+ val jobGroupIdOpt =
Option(properties).map(_.getProperty(SparkContext.SPARK_JOB_GROUP_ID))
+ if (jobGroupIdOpt.exists(cancelledJobGroups.contains(_))) {
Review Comment:
The `handler` function are run in the synchronized block, so the
"`cancelJobGroup(cancelFutureJobs = true)` => the current active jobs will be
cancelled + this job group is added to the set" should be run atomically. And
later the future job belonging to this job group will be cancelled on
submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
