juliuszsompolski commented on PR #43962: URL: https://github.com/apache/spark/pull/43962#issuecomment-1823462182
> Thank you for finding out this. >> In grpc 1.56, when calling a server streaming RPC like client.execute, the request would not be send to server until the first interaction with the resulting iterator (next or hasNext). In grpc 1.59, it appears that the request is send to the server immediately. @dongjoon-hyun this has already been found by @HyukjinKwon in https://github.com/apache/spark/pull/43955. @HyukjinKwon fix there was to modify `ExecutePlanResponseReattachableIterator` to preserve the old behaviour by making the iterator creation lazy. I propose that it's OK to change this behavior. There is a small user-facing change consequence of that, described in the PR description. Personally find that the old behavior was quirky and prefer that the request is sent eagerly. But it is a change, so I think it's good for others to also express their opinion about it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
