juliuszsompolski commented on code in PR #43962:
URL: https://github.com/apache/spark/pull/43962#discussion_r1402685087
##########
connector/connect/server/src/test/scala/org/apache/spark/sql/connect/service/SparkConnectServiceE2ESuite.scala:
##########
@@ -75,13 +71,6 @@ class SparkConnectServiceE2ESuite extends
SparkConnectServerTest {
query2Error.getMessage.contains("OPERATION_CANCELED") ||
query2Error.getMessage.contains("INVALID_HANDLE.OPERATION_ABANDONED"))
- // query3 has not been submitted before, so it should now fail with
SESSION_CLOSED
- // TODO(SPARK-46042) Reenable a `releaseSession` test case in
SparkConnectServiceE2ESuite
- val query3Error = intercept[SparkException] {
- query3.hasNext
- }
- assert(query3Error.getMessage.contains("INVALID_HANDLE.SESSION_CLOSED"))
-
Review Comment:
This case was specifically testing the (in my opinion) quirky behavior that
requests are not sent until the response iterator is opened. So if that
behavior is gone, and we agree to not emulate it back like
https://github.com/apache/spark/pull/43955 did, then the test is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
