Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/6423#discussion_r31093738
--- Diff:
core/src/main/scala/org/apache/spark/storage/ShuffleBlockFetcherIterator.scala
---
@@ -29,6 +30,16 @@ import org.apache.spark.serializer.{SerializerInstance,
Serializer}
import org.apache.spark.util.{CompletionIterator, Utils}
/**
+ * Factory class that creates iterators to read records from fetched blocks
+ */
+trait BlockRecordIteratorFactory {
--- End diff --
Is this class intended to be public? It might be okay as a developer API
but I don't think that we should commit to making any of the shuffle internals
as stable public interfaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
