cloud-fan commented on code in PR #43910:
URL: https://github.com/apache/spark/pull/43910#discussion_r1403387271


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/percentiles.scala:
##########
@@ -350,6 +352,36 @@ case class Median(child: Expression)
       newChild: Expression): Median = this.copy(child = newChild)
 }
 
+/**
+ * A factory used to create the inverse distribution function during the 
analysis phase.
+ * This factory is also an aggregate function that cannot be evaluated.
+ */
+trait InverseDistributionFactory extends AggregateFunction {

Review Comment:
   We still need a base trait
   ```
   trait SupportsOrderingWithinGroup { self: AggregateFunction =>
     def withOrderingWithinGroup(orderingWithGroup: Seq[SortOrder]): Expression
   }
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to