beliefer commented on code in PR #43910:
URL: https://github.com/apache/spark/pull/43910#discussion_r1404331597
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -975,6 +975,7 @@ primaryExpression
| LEFT_PAREN query RIGHT_PAREN
#subqueryExpression
| functionName LEFT_PAREN (setQuantifier? argument+=functionArgument
(COMMA argument+=functionArgument)*)? RIGHT_PAREN
+ (WITHIN GROUP LEFT_PAREN ORDER BY sortItem RIGHT_PAREN)?
Review Comment:
I checked the inverse distribution functions in Postgres and Oracle
Postgres throws
```
SQL 错误 [42883]: ERROR: function percentile_cont(numeric, numeric, double
precision) does not exist
建议：No function matches the given name and argument types. You might need
to add explicit type casts.
位置：52
```
Oracle throws
`SQL 错误 [909] [42000]: ORA-00909: 参数个数无效`
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -975,6 +975,7 @@ primaryExpression
| LEFT_PAREN query RIGHT_PAREN
#subqueryExpression
| functionName LEFT_PAREN (setQuantifier? argument+=functionArgument
(COMMA argument+=functionArgument)*)? RIGHT_PAREN
+ (WITHIN GROUP LEFT_PAREN ORDER BY sortItem RIGHT_PAREN)?
Review Comment:
I checked the inverse distribution functions in Postgres and Oracle
Postgres throws
```
SQL 错误 [42883]: ERROR: function percentile_cont(numeric, numeric, double
precision) does not exist
建议：No function matches the given name and argument types. You might need
to add explicit type casts.
位置：52
```
Oracle throws
`SQL 错误 [909] [42000]: ORA-00909: 参数个数无效`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
