heyihong commented on code in PR #43959:
URL: https://github.com/apache/spark/pull/43959#discussion_r1406500680
##########
sql/core/src/main/scala/org/apache/spark/sql/internal/CatalogImpl.scala:
##########
@@ -415,14 +408,16 @@ class CatalogImpl(sparkSession: SparkSession) extends
Catalog {
}
}
- private def getNamespace(catalog: CatalogPlugin, ns: Seq[String]): Database
= catalog match {
+ private def getNamespace(
+ catalog: CatalogPlugin,
+ ns: Seq[String],
+ metadata: Map[String, String]): Database = catalog match {
case catalog: SupportsNamespaces =>
Review Comment:
Good point, if I understand correctly, catalog should not be null so it
should be safe to always call `catalog.name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
