cloud-fan commented on code in PR #43959:
URL: https://github.com/apache/spark/pull/43959#discussion_r1406743762
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala:
##########
@@ -50,10 +52,18 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
case CurrentNamespace =>
ResolvedNamespace(currentCatalog,
catalogManager.currentNamespace.toImmutableArraySeq)
- case UnresolvedNamespace(Seq()) =>
- ResolvedNamespace(currentCatalog, Seq.empty[String])
- case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
- ResolvedNamespace(catalog, ns)
+ case UnresolvedNamespace(Seq(), _) =>
+ ResolvedNamespace(currentCatalog, Seq.empty[String], Map.empty)
Review Comment:
Nil is also a valid namespace in DS v2.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveCatalogs.scala:
##########
@@ -50,10 +52,18 @@ class ResolveCatalogs(val catalogManager: CatalogManager)
case CurrentNamespace =>
ResolvedNamespace(currentCatalog,
catalogManager.currentNamespace.toImmutableArraySeq)
- case UnresolvedNamespace(Seq()) =>
- ResolvedNamespace(currentCatalog, Seq.empty[String])
- case UnresolvedNamespace(CatalogAndNamespace(catalog, ns)) =>
- ResolvedNamespace(catalog, ns)
+ case UnresolvedNamespace(Seq(), _) =>
+ ResolvedNamespace(currentCatalog, Seq.empty[String], Map.empty)
Review Comment:
Nil (the root namespace) is also a valid namespace in DS v2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
