Ngone51 commented on code in PR #43954:
URL: https://github.com/apache/spark/pull/43954#discussion_r1408807471
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -1871,21 +1871,6 @@ private[spark] class DAGScheduler(
markStageAsFinished(resultStage)
cancelRunningIndependentStages(job, s"Job ${job.jobId} is
finished.")
cleanupStateForJobAndIndependentStages(job)
- try {
- // killAllTaskAttempts will fail if a SchedulerBackend
does not implement
- // killTask.
- logInfo(s"Job ${job.jobId} is finished. Cancelling
potential speculative " +
- "or zombie tasks for this job")
- // ResultStage is only used by this job. It's safe to
kill speculative or
- // zombie tasks in this stage.
- taskScheduler.killAllTaskAttempts(
Review Comment:
It turns out that we should switch the order beween `markStageAsFinished`
and `cancelRunningIndependentStages` after removing this code block.
`markStageAsFinished` removes the stage from `runningStages` and
`cancelRunningIndependentStages` only cleanup stages that exist in
`runningStages`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
