cloud-fan commented on code in PR #43954:
URL: https://github.com/apache/spark/pull/43954#discussion_r1409276985
##########
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala:
##########
@@ -1004,6 +1004,17 @@ private[spark] class TaskSetManager(
maybeFinishTaskSet()
}
+ // Suspends this TSM to avoid launching new tasks.
+ //
+ // Unlike `abort()`, this function intentionally to not notify DAGScheduler
to avoid
+ // redundant operations. So the invocation to this function should assume
DAGScheduler
Review Comment:
So how expensive is the redundant operation? We may choose to always do them
if it's cheap, to simplify the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
