mridulm commented on code in PR #43954:
URL: https://github.com/apache/spark/pull/43954#discussion_r1409479495
##########
core/src/main/scala/org/apache/spark/scheduler/DAGScheduler.scala:
##########
@@ -1894,24 +1894,8 @@ private[spark] class DAGScheduler(
job.numFinished += 1
// If the whole job has finished, remove it
if (job.numFinished == job.numPartitions) {
- markStageAsFinished(resultStage)
Review Comment:
They are not the same @Ngone51 - `markStageAsFinished` is for successful
stage completions (when no `reason`), while `cancelRunningIndependentStages` is
aborting other stages for the job which now need to be killed due to the job
successfully terminating.
One impact of this is in the `errorMessage` - it will be `nonEmpty` from
`cancelRunningIndependentStages` and so trigger failure paths.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
