LuciferYang commented on code in PR #44173:
URL: https://github.com/apache/spark/pull/44173#discussion_r1414940118
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -186,6 +186,10 @@ private[deploy] class Master(
val fsFactory =
new FileSystemRecoveryModeFactory(conf, serializer)
(fsFactory.createPersistenceEngine(),
fsFactory.createLeaderElectionAgent(this))
+ case "ROCKSDB" =>
Review Comment:
Is this configuration item required to be `ROCKSDB`? Is it not allowed to
configure it as `rocksdb` or `Rocksdb` now? （Perhaps this is a legacy issue?）
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -186,6 +186,10 @@ private[deploy] class Master(
val fsFactory =
new FileSystemRecoveryModeFactory(conf, serializer)
(fsFactory.createPersistenceEngine(),
fsFactory.createLeaderElectionAgent(this))
+ case "ROCKSDB" =>
Review Comment:
Is this configuration item required to be `ROCKSDB`? Is it not allowed to
configure it as `rocksdb` or `Rocksdb` now? （Perhaps this is a legacy issue?）
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
